Skip to content

Commit

Permalink
fix: remove failing BrokenRecorder test; it doesn't exist in >v10
Browse files Browse the repository at this point in the history
  • Loading branch information
rosstimothy committed Dec 20, 2022
1 parent e166914 commit d0e21bd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion lib/srv/exec_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func TestOSCommandPrep(t *testing.T) {
fmt.Sprintf("SSH_TTY=%v", scx.session.term.TTY().Name()),
"SSH_SESSION_ID=xxx",
"SSH_SESSION_WEBPROXY_ADDR=<proxyhost>:3080",
"SSH_TELEPORT_HOST_UUID=test",
"SSH_TELEPORT_HOST_UUID=testID",
"SSH_TELEPORT_CLUSTER_NAME=localhost",
"SSH_TELEPORT_USER=teleportUser",
}
Expand Down
11 changes: 0 additions & 11 deletions lib/srv/sess_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,17 +273,6 @@ func TestInteractiveSession(t *testing.T) {
}
require.Eventually(t, sessionClosed, time.Second*15, time.Millisecond*500)
})

t.Run("BrokenRecorder", func(t *testing.T) {
t.Parallel()
sess, _ := testOpenSession(t, reg, nil)

// The recorder might be closed in the case of an error downstream.
// Closing the session recorder should result in the session ending.
err := sess.recorder.Close(context.Background())
require.NoError(t, err)
require.Eventually(t, sess.isStopped, time.Second*5, time.Millisecond*500)
})
}

// TestStopUnstarted tests that a session may be stopped before it launches.
Expand Down

0 comments on commit d0e21bd

Please sign in to comment.