Skip to content

Commit

Permalink
Fix linter errors introduced by #47841 (#47913)
Browse files Browse the repository at this point in the history
This fixes a few non-Linux lints introduced in #47841, where
staticcheck complains about noop implementations for non-Linux OSes.

It also removes an outdated TODO comment.
  • Loading branch information
timothyb89 authored Oct 24, 2024
1 parent 05d3371 commit ce70671
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/tbot/config/destination_directory.go
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,8 @@ func (dd *DestinationDirectory) Verify(keys []string) error {

// verifyAndCorrectACL performs validation and attempts correction on new-style
// ACLs when configured.
//
//nolint:staticcheck // staticcheck doesn't like nop implementations in fs_other.go
func (dd *DestinationDirectory) verifyAndCorrectACL(ctx context.Context, subpath string) error {
p := filepath.Join(dd.Path, subpath)

Expand All @@ -380,8 +382,6 @@ func (dd *DestinationDirectory) verifyAndCorrectACL(ctx context.Context, subpath
// as hard failures.
if len(issues) > 0 {
if err := botfs.ConfigureACL(p, dd.Readers); err != nil {
// TODO: should this always be a hard fail? Would we want to just
// warn on `acls: try`?
return trace.Wrap(err, "unable to fix misconfigured ACL at path %s with issues %v", p, issues)
}

Expand Down

0 comments on commit ce70671

Please sign in to comment.