Skip to content

Commit

Permalink
Resolve comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Joerger committed May 2, 2022
1 parent 4259a31 commit c3a826f
Show file tree
Hide file tree
Showing 10 changed files with 133 additions and 113 deletions.
98 changes: 55 additions & 43 deletions api/client/proto/authservice.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 15 additions & 3 deletions api/client/proto/authservice.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1527,62 +1527,74 @@ message ListResourcesResponse {
// CreateSessionTrackerRequest is a request to create a new session.
//
// This is not specific to any session type. Relevant fields should be set for a given session type.
//
// TODO(bjoerger): Deprecate/reserve fields 1 to 14 in favor of seessionTracker field.
message CreateSessionTrackerRequest {
// Namespace is a session namespace, separating sessions from each other.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string Namespace = 1 [ (gogoproto.jsontag) = "namespace,omitempty" ];

// Type describes what type of session this is.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string Type = 2 [ (gogoproto.jsontag) = "type,omitempty" ];

// Reason is an arbitrary string that may be used to describe the session and/or it's
// purpose.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string Reason = 3 [ (gogoproto.jsontag) = "reason,omitempty" ];

// Invited is a list of invited users, this field is interpreted by different
// clients on a best-effort basis and used for delivering notifications to invited users.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
repeated string Invited = 4 [ (gogoproto.jsontag) = "invited,omitempty" ];

// Hostname is the address of the target this session is connected to.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string Hostname = 5 [ (gogoproto.jsontag) = "target_hostname,omitempty" ];

// Address is the address of the target this session is connected to.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string Address = 6 [ (gogoproto.jsontag) = "target_address,omitempty" ];

// ClusterName is the name of cluster that this session belongs to.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string ClusterName = 7 [ (gogoproto.jsontag) = "cluster_name,omitempty" ];

// Login is the local login/user on the target used by the session.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string Login = 8 [ (gogoproto.jsontag) = "login,omitempty" ];

// Initiator is the participant that initiated the session.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
types.Participant Initiator = 9 [ (gogoproto.jsontag) = "initiator,omitempty" ];

// Expires encodes the time at which this session expires and becomes invalid.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
google.protobuf.Timestamp Expires = 10 [
(gogoproto.stdtime) = true,
(gogoproto.nullable) = false,
(gogoproto.jsontag) = "expires,omitempty"
];

// The Kubernetes cluster this session belongs to.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string KubernetesCluster = 11 [ (gogoproto.jsontag) = "kubernetes_cluster,omitempty" ];

// HostUser is the user regarded as the owner of this session, RBAC checks are performed
// against the require policies of this user.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string HostUser = 12 [ (gogoproto.jsontag) = "host_user,omitempty" ];

// ID is the ID of the session.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
string ID = 13 [ (gogoproto.jsontag) = "id,omitempty" ];

// HostPolicies is a list of RBAC policy sets held by the host user at the time of session
// creation.
// DELETE IN V11 - deprecated/reserve in favor of SessionTracker field.
repeated types.SessionTrackerPolicySet HostPolicies = 14
[ (gogoproto.jsontag) = "host_policies,omitempty" ];

// sessionTracker is the session tracker to be created.
types.SessionTrackerV1 sessionTracker = 15
types.SessionTrackerV1 SessionTracker = 15
[ (gogoproto.jsontag) = "session_tracker,omitempty" ];
}

Expand Down
Loading

0 comments on commit c3a826f

Please sign in to comment.