Clean up imports and remove extra comments

gravitational · Oct 24, 2024 · 9c96761 · 9c96761
1 parent 66d87d8
commit 9c96761
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 14 deletions.
diff --git a/web/packages/shared/components/AccessRequests/NewRequest/RequestCheckout/RequestCheckout.tsx b/web/packages/shared/components/AccessRequests/NewRequest/RequestCheckout/RequestCheckout.tsx
@@ -48,7 +48,6 @@ import { FieldCheckbox } from 'shared/components/FieldCheckbox';
 import { mergeRefs } from 'shared/libs/mergeRefs';
 import { TextSelectCopyMulti } from 'shared/components/TextSelectCopy';
 import { RequestableResourceKind } from 'shared/components/AccessRequests/NewRequest/resource';
-import { TextSelectCopyMulti } from 'shared/components/TextSelectCopy';
 
 import { CreateRequest } from '../../Shared/types';
 import { AssumeStartTime } from '../../AssumeStartTime/AssumeStartTime';

diff --git a/web/packages/shared/components/AccessRequests/NewRequest/RequestCheckout/index.ts b/web/packages/shared/components/AccessRequests/NewRequest/RequestCheckout/index.ts
@@ -17,7 +17,11 @@
  */
 
 export { RequestCheckoutWithSlider, RequestCheckout } from './RequestCheckout';
-export type { RequestCheckoutProps, PendingListItem } from './RequestCheckout';
+export type {
+  RequestCheckoutProps,
+  PendingListItem,
+  PendingKubeResourceItem,
+} from './RequestCheckout';
 
 export * from './utils';
 export type { ReviewerOption } from './types';
diff --git a/web/packages/shared/components/AccessRequests/NewRequest/index.ts b/web/packages/shared/components/AccessRequests/NewRequest/index.ts
@@ -20,3 +20,5 @@ export * from './RequestCheckout';
 export * from './ResourceList';
 export type { ResourceMap, RequestableResourceKind } from './resource';
 export { getEmptyResourceState } from './resource';
+export type { KubeNamespaceRequest } from './kube';
+export { isKubeClusterWithNamespaces } from './kube';
diff --git a/web/packages/teleterm/src/ui/AccessRequestCheckout/useAccessRequestCheckout.ts b/web/packages/teleterm/src/ui/AccessRequestCheckout/useAccessRequestCheckout.ts
@@ -24,15 +24,13 @@ import useAttempt from 'shared/hooks/useAttemptNext';
 import {
   getDryRunMaxDuration,
   PendingListItem,
+  PendingKubeResourceItem,
+  isKubeClusterWithNamespaces,
+  KubeNamespaceRequest,
 } from 'shared/components/AccessRequests/NewRequest';
 import { useSpecifiableFields } from 'shared/components/AccessRequests/NewRequest/useSpecifiableFields';
 
 import { CreateRequest } from 'shared/components/AccessRequests/Shared/types';
-import {
-  isKubeClusterWithNamespaces,
-  KubeNamespaceRequest,
-} from 'shared/components/AccessRequests/NewRequest/kube';
-import { PendingKubeResourceItem } from 'shared/components/AccessRequests/NewRequest/RequestCheckout/RequestCheckout';
 
 import { useAppContext } from 'teleterm/ui/appContextProvider';
 import {
@@ -161,7 +159,6 @@ export default function useAccessRequestCheckout() {
   }, [showCheckout, hasExited, createRequestAttempt.status]);
 
   /**
-   *
    * @param pendingRequest holds a list or map of resources to process
    */
   function getPendingAccessRequestsPerResource(

diff --git a/web/packages/teleterm/src/ui/services/workspacesService/accessRequestsService.ts b/web/packages/teleterm/src/ui/services/workspacesService/accessRequestsService.ts
@@ -327,12 +327,6 @@ export function extractResourceRequestProperties({
   id: string;
   /**
    * Can refer to a pretty name of the resource (can be the same as `id`)
-   * or refer to a subresource name.
-   *
-   * For example:
-   * - for nodes, we want to show hostname (pretty) instead of its id.
-   * - for a kube subresource like "namespace", it'll refer to its name
-   *
    */
   name: string;
 } {