Skip to content

Commit

Permalink
Add todo for x11 test improvments.
Browse files Browse the repository at this point in the history
  • Loading branch information
Joerger committed Feb 4, 2022
1 parent 23cf2e0 commit 39be324
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/sshutils/x11/auth_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,10 @@ func TestXAuthCommands(t *testing.T) {
require.True(t, trace.IsNotFound(err))
require.Nil(t, xauthEntry)

// Generate untrusted xauth entry - This command requires an actual display for an
// an actual XServer, so we use localDisplay if set.
// TODO(Joerger): Currently this test will only run/pass locally if you have $DISPLAY
// set. We need to add Xorg to the buildbox and start an XServer in order to run
// this test in CI. Additionally, Xorg and x11-apps can be used to add more tests
// and rework current tests which depend on fake display listeners instead.
localDisplay, err := GetXDisplay()
if trace.IsBadParameter(err) {
t.Skip("skipping xauth generate test, DISPLAY isn't set")
Expand Down

0 comments on commit 39be324

Please sign in to comment.