Fix horizontal scroll and extended key codes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library includes support for sending horizontal mouse wheel events, but it forgets to send the TsInputFlagMouseHwheel capability to the server when the connection is established. See https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpbcgr/b3bc76ae-9ee5-454f-b197-ede845ca69cc Updates: gravitational/teleport#8742 See also: gravitational/webapps#437
ibeckermayer
approved these changes
Oct 29, 2021
r0mant
approved these changes
Oct 29, 2021
russjones
reviewed
Oct 29, 2021
| @@ -362,13 +362,13 @@ pub enum InputFlags { | |||
| InputFlagFastpathInput = 0x0008, | |||
| /// In order to send keyboard scancode | |||
| /// We can send directly UNICODE code of char | |||
| /// Usefull if we want to send script | |||
| /// Useful if we want to send script | |||
There was a problem hiding this comment.
Doc comments, yes. Regular comments no.
zmb3
added a commit
to gravitational/teleport
that referenced
this pull request
Oct 29, 2021
This pulls in the fixes from gravitational/rdp-rs#4 Updates #8742 Backport to v8 required.
zmb3
added a commit
to gravitational/teleport
that referenced
this pull request
Nov 1, 2021
This pulls in the fixes from gravitational/rdp-rs#4 Updates #8742 Backport to v8 required.
zmb3
added a commit
to gravitational/teleport
that referenced
this pull request
Nov 1, 2021
This pulls in the fixes from gravitational/rdp-rs#4 Updates #8742 Backport to v8 required.
zmb3
added a commit
to gravitational/teleport
that referenced
this pull request
Nov 1, 2021
This pulls in the fixes from gravitational/rdp-rs#4 Updates #8742 Backport to v8 required.
zmb3
added a commit
to gravitational/teleport
that referenced
this pull request
Nov 2, 2021
This pulls in the fixes from gravitational/rdp-rs#4 Updates #8742 Backport to v8 required.
zmb3
added a commit
to gravitational/teleport
that referenced
this pull request
Nov 3, 2021
This pulls in the fixes from gravitational/rdp-rs#4 Updates #8742 Backport to v8 required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library includes support for sending horizontal mouse wheel events,
but it forgets to send the TsInputFlagMouseHwheel capability to the
server when the connection is established.
See https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpbcgr/b3bc76ae-9ee5-454f-b197-ede845ca69cc
Updates: gravitational/teleport#8742
See also: gravitational/webapps#437