Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit dependency on golang.org/x/sys #3

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Add explicit dependency on golang.org/x/sys #3

merged 2 commits into from
Sep 12, 2022

Conversation

nklaassen
Copy link

@nklaassen nklaassen commented Sep 9, 2022 •
edited
Loading

I found this was necessary in order to build this package with go1.18, otherwise I got the following errors:

$ go build .
# golang.org/x/sys/unix
../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../go/pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:121:3: too many errors

All I ran here was go get -u golang.org/x/sys && go mod tidy, based on the suggestion here: golang/go#51706 (comment)

@nklaassen nklaassen merged commit 884b019 into master Sep 12, 2022
@nklaassen nklaassen deleted the nklaassen/deps branch December 6, 2022 17:15
nklaassen added a commit that referenced this pull request Dec 6, 2022
@nklaassen
Revert "Add explicit dependency on golang.org/x/sys (#3)"
32b40a5 
This reverts commit 884b019.

Merging the solution from the upstream vulcand/predicate instead.
nklaassen added a commit that referenced this pull request Dec 6, 2022
@nklaassen @ldez @hxysayhi
Merge upstream changes from vulcand/predicate (#7)
77c8eac 
* chore: update go version

* docs: fix the bug in the example (#10)

* chore: update dependencies

* Revert "chore: update dependencies"

This reverts commit 4d72487.

* feat: update dependencies

* chore: update linter and CI

* Revert "Add explicit dependency on `golang.org/x/sys` (#3)"

This reverts commit 884b019.

Merging the solution from the upstream vulcand/predicate instead.

* lint fixes

Co-authored-by: Fernandez Ludovic <[email protected]>
Co-authored-by: hxysayhi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klizhentas klizhentas klizhentas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nklaassen @klizhentas