This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
Reset any control plane units that failed to stop. #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
r0mant
approved these changes
Jun 19, 2020
knisbet
reviewed
Jun 22, 2020
| // Even if 'systemctl stop' did not fail, the service could have failed stopping | ||
| // even though 'stop' is blocking, it does not return an error upon service failing. | ||
| // See github.com/gravitational/gravity/issues/1209 for more details | ||
| if err := systemctlCmd(ctx, "is-failed", unit); err == nil { |
There was a problem hiding this comment.
Sorry, I just realized something I missed on the non-backport PR. Since we pass no-block to the underlying systemctl command, will a unit enter the failed state before we check the is-failed status, since presumably the unit is allowed some amount of time to shutdown?
There was a problem hiding this comment.
We don't pass no-block to systemctl here - so it should be good given the possibility that dbus command could still fail which we'll address with reconciler loop changes.
There was a problem hiding this comment.
Ah my bad, I was looking at the wrong function signature when that stood out to me.
* Reset any control plane units that failed to stop. * Address review comments Updates github.com/gravitational/gravity/issues/1209.
a-palchikov
force-pushed
the
dmitri/1209-reset-failed
branch
from
19db43e
to
d8b999b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #685.
Updates github.com/gravitational/gravity/issues/1209.