This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
Dmitri/sanity tests #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- component statuses - etcd - systemd/monit
- added named reporter to not have to specify checker name in
Checker.Check
- removed Context in favour of separate two arguments: reporter /
config
and checker/Checker interfaces.
Moved systemd/monit checkers from lib/monitoring -> agent/monitoring.
available). Extended monitoring.Reporter interface with a method that accepts an monitoring.Event.
- agent is concerned with serf integration / defining health interfaces - monitoring package implements the health checkers for agent
Using grpc for agent RPC.
Removed serf agent IPC in favour of grpc-based RPC mechanism.
encoding/decoding. Completed status query to properly report `degraded` status for both nodes and whole cluster. Changed status query to report `running` services for completeness (if the output is complete, `failed` states can be filtered but not the other way around).
useful external utilization of serf by unnecessarily coupling it to planet. Revisited the agent to use serf RPC for events and membership. Rewrote query to use agent RPC to request status of other members.
Dropped support for monit.
- serf and its dependencies - sqlx
Merged with master. Fixed a passwd/group host->container modification problem when the container passwd/group files were appended to instead of being rewritten. Extended planet-agent systemd unit file to include command line for health agent. Conflicts: Godeps/Godeps.json Godeps/_workspace/src/github.com/pborman/uuid/sql.go Godeps/_workspace/src/golang.org/x/net/context/context.go build.assets/makefiles/common-docker.mk build.assets/makefiles/master/k8s-master/k8s-e2e.mk tool/planet/agent.go tool/planet/cfg.go tool/planet/main.go tool/planet/start.go
status reports when both cluster-level as well local status queries are made. Changed planet-agent / serf systemd unit files to explicitly bind to public-ip.
localhost communiction while still being able to inter-communicate within cluster.
Fixed (hopefully, until a proper go-systemd update) systemd checker leaking systemd dbus.Conn instances. Moved default pretty-printing to an option for `planet status` to be backwards-compatible with the previous command line intreface.
Fixed the unconditional DNS bootstrap -> only bootstrap on current master.
healthy cluster status with unhealthy nodes and added extra test case. Removed old status function that delegated to another planet instance in favour of agent RPC call.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to start the review - some things are still moving - PR contains a fair share of
FIXMEs.I started with the
--peersflag and implemented it as a list but this will probably be problematic and easier to use if it took a comma-separated value - todo.Otherwise, the serf has been factored out - this is really a good idea.