This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
[6.x] Move grafana dashboards into container #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
Jun 11, 2020
UnderGreen
changed the title
a-palchikov
reviewed
Jun 13, 2020
| kubectl --namespace=monitoring patch daemonsets.apps $daemonset --type=json -p='[{"op": "replace", "path": "/metadata/managedFields", "value": [{}]}]' || true | ||
| kubectl --namespace=monitoring patch daemonsets.apps $daemonset --type=json -p='[{"op": "remove", "path": "/metadata/annotations/kubectl.kubernetes.io~1last-applied-configuration"}]' || true | ||
| done | ||
| for configmap in adapter-config grafana-cfg prometheus-k8s-rulefiles-0 grafana-dashboard-k8s-cluster-rsrc-use grafana-dashboard-k8s-resources-cluster \ |
There was a problem hiding this comment.
nit: it would make editing easier if we moved the resource names into respective variables
| do | ||
| # || true is needed in case resources does not have last applied configuration | ||
| kubectl --namespace=monitoring patch deployments.apps $deployment --type=json -p='[{"op": "replace", "path": "/metadata/managedFields", "value": [{}]}]' || true | ||
| kubectl --namespace=monitoring patch deployments.apps $deployment --type=json -p='[{"op": "remove", "path": "/metadata/annotations/kubectl.kubernetes.io~1last-applied-configuration"}]' || true |
There was a problem hiding this comment.
Can you explain the syntax of ~1 (if that's not a typo):
/metadata/annotations/kubectl.kubernetes.io~1last-applied-configuration
There was a problem hiding this comment.
~ is the way to replace / in annotation key name:
https://stackoverflow.com/a/55575415
https://tools.ietf.org/html/rfc6901#section-3
There was a problem hiding this comment.
wow, that's some great design on the json pointer - make it even more unreadable. Ok, I see - so basically the annotation key is encoded with a different encoder that implements RFC6901 and turns / into ~1.
a-palchikov
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #172 for Gravity 6.1.x.