Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

(5.5) Add command for updating teleport node auth servers #1944

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

r0mant
Copy link
Contributor

@r0mant r0mant commented Jul 30, 2020

Description

Add a system CLI command for manipulating another part of teleport configuration - auth servers, to provide a manual recovery way for #1515.

Type of change

  • New feature (non-breaking change which adds functionality)

Linked tickets and other PRs

TODOs

  • Self-review the change
  • Perform manual testing
  • Write documentation
  • Address review feedback

Testing done

Install a cluster. Check teleport config:

ubuntu@node-1:~/installer$ sudo gravity system teleport show-config --package=node
Using Teleport node config from test/teleport-node-config-19216899102test:3.0.5
teleport:
  ...
  auth_servers:
  - 127.0.0.1:3025
  - 192.168.99.102:3025
  ...

Update auth servers:

ubuntu@node-1:~/installer$ sudo gravity system teleport set-auth-servers --auth-server=192.168.99.103
Using Teleport node config from test/teleport-node-config-19216899102test:3.0.5
Teleport node auth servers updated. Please restart Teleport service using 'sudo systemctl restart *teleport*'

Check config again and make sure new auth server is there:

ubuntu@node-1:~/installer$ sudo gravity system teleport show-config --package=node
Using Teleport node config from test/teleport-node-config-19216899102test:3.0.5
teleport:
  ...
  auth_servers:
  - 127.0.0.1:3025
  - 192.168.99.102:3025
  - 192.168.99.103:3025
  ...

Additional information

Will also need to write a KB article for this.

@r0mant r0mant requested a review from a team July 30, 2020 02:26
@r0mant r0mant self-assigned this Jul 30, 2020
Copy link
Contributor

@a-palchikov a-palchikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we should offer the ability to replace the whole configuration file?

@r0mant
Copy link
Contributor Author

r0mant commented Jul 30, 2020

@a-palchikov I thought exactly the same. On the other hand, having commands to update specific things leaves less room for error for the users (esp. given this is a last resort workaround). I still think having a command to update teleport node config will be definitely useful, even for ourselves, maybe will do it in newer branches.

@r0mant r0mant merged commit e2fd0fd into version/5.5.x Jul 30, 2020
@r0mant r0mant deleted the roman/5.5/authservers branch July 30, 2020 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants