Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

(7.0) Allow execution of upload from other directories #1892

Merged
merged 2 commits into from
Jul 18, 2020

Conversation

wadells
Copy link
Contributor

@wadells wadells commented Jul 17, 2020

Description

This is a backport of #1843 per a request from a user.

This fixes the following issue:

$ sudo ~/7.0.11/upgrade
/home/robotest/7.0.11/upload: line 12: ./gravity: No such file or directory

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Internal change (not necessarily a bug fix or a new feature)
  • This change has a user-facing impact

Linked tickets and other PRs

Ports #1843

TODOs

  • Self-review the change
  • Perform manual testing
  • Address review feedback

Testing done

Before:

$ sudo ~/7.0.13/upgrade
/home/robotest/7.0.13/upload: line 12: ./gravity: No such file or directory

After:

$ sudo ~/7.0.13/upgrade
Fri Jul  17 23:10:28 UTC Importing application telekube v7.0.13
Fri Jul  17 23:11:15 UTC Synchronizing application with Docker
// etc

I didn't actually rebuild a tarball, I just edited the script and then ported that to this go file.

Without this, if upgrade was run from any directory but its own, it
would fail with the following message:

  $ sudo ~/7.0.11/upgrade
  /home/robotest/7.0.11/upload: line 12: ./gravity: No such file or directory

(cherry picked from commit d4b3c67)
@wadells wadells requested review from a team, r0mant and knisbet July 17, 2020 23:19
@wadells wadells merged commit 660baff into version/7.0.x Jul 18, 2020
@wadells wadells deleted the walt/7.0-relative-upload branch August 21, 2020 05:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants