Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

[5.5.x] upgrade/resume backport #1526

Merged
merged 2 commits into from
May 13, 2020

Conversation

a-palchikov
Copy link
Contributor

Type of change

This PR backports the improvements made to upstream after the original (i.e. 5.5.x) PR has been merged.

  • Bug fix (non-breaking change which fixes an issue)
  • This change has a user-facing impact

Linked tickets and other PRs

TODOs

  • Self-review the change
  • Perform manual testing
  • Address review feedback

Implementation

Testing done

error for an unstarted install operation

$ ./gravity plan resume
...
Mon May  4 17:48:34 UTC	Connecting to installer
[ERROR]: failed to find installer service. Use 'gravity install' to start new installation or 'gravity join' to join the existing cluster.
	no service unit file in /home/centos/.gravity

error for resuming on an existing cluster

# ./gravity plan resume
[ERROR]: no active operation found

explicit resumption of the upgrade operation and no operation is active:

$ ./gravity upgrade --resume
[ERROR]: no active update operation found

explicit resumption of the join operation and no operation is active:

$ ./gravity join --resume
[ERROR]: no active expand operation found

clear message on expand depending on whether the cluster is degraded or another operation is in progress:

Cluster is degraded, waiting for it to become healthy

vs

Waiting for another operation to complete at 10.128.0.104

@a-palchikov a-palchikov requested review from a team, r0mant and knisbet May 8, 2020 17:37
@@ -362,17 +359,6 @@ type backendOperations struct {
clusterOperation *clusterOperation
}

// formatTable formats this operation list as a table
func (r operationList) formatTable() string {
Copy link
Contributor

@r0mant r0mant May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using this function in my gravity rollback work, can we keep it? Unless there's another way to format operation(-s) as a table.

@a-palchikov a-palchikov merged commit 3c68a4b into version/5.5.x May 13, 2020
@a-palchikov a-palchikov deleted the dmitri/5.5.x/1471-upgrade-resume branch May 13, 2020 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants