Use static clusters instead of EDS #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that when a cluster is updated without a following endpoint update a cluster can lose its endpoint configuration. I attempted to update endpoints on each cluster change to prevent this but it was still possible for the cluster update to happen after the endpoint update. This appears related to envoyproxy/envoy#13009 By using static clusters the endpoints are included in the cluster update. In testing this appears to resolve the issue where endpoints disappear since we no longer rely on EDS.
|
Missing test changes? 🙂 Also, should we open an upstream issue? Even if it's already know, seems like a bug report could be useful data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that when a cluster is updated without a following endpoint update a cluster can lose its endpoint configuration.
I attempted to update endpoints on each cluster change to prevent this but it was still possible for the cluster update to happen after the endpoint update.
This seems related to envoyproxy/envoy#13009
By using static clusters the endpoints are included in the cluster update. In testing this appears to resolve the issue where endpoints disappear since we no longer rely on EDS.