fix: 🩹improve error handling in PCICReceiver #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the error handling in the `PCICReceiver` struct by updating the `Error` method to print the error message with the error ID. It also adds a new method `errorParser` to the `PCICClient` struct that parses the error message from the given data string. This method uses a regular expression to extract the error ID and message. Additionally, it handles the case where the error ID is all zeros.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #19 +/- ##
==========================================
- Coverage 22.52% 22.43% -0.10%
==========================================
Files 23 23
Lines 1323 1333 +10
==========================================
+ Hits 298 299 +1
- Misses 1020 1026 +6
- Partials 5 8 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the error handling in the
PCICReceiverstruct by updating theErrormethod to print the error message with the error ID. It also adds a new methoderrorParserto thePCICClientstruct that parses the error message from the given data string. This method uses a regular expression to extract the error ID and message. Additionally, it handles the case where the error ID is all zeros.