Persist email messages

[chadwhitacre]

← Factor out email tests (#4570) — Persist email verifications (#4573) →

---

Previously the email queue was ephemeral. We would delete messages from it after successfully firing them off to SES. That prevents us from doing several things:

• properly handling bounces and complaints (Process bounces and complaints automatically #4284)
• sending instantly while also throttling (Send email messages immediately #4545)
• limiting verification emails properly (Mitigate npm spam/phishing #4557)

This PR:

• changes email_queue to email_messages, a table that we never delete from
• changes emails to email_addresses to disambiguate

Todo

• store MessageId

[chadwhitacre]

Ready for review, @rohitpaulk! :-)

[chadwhitacre]

As we start persisting messages, we should store the MessageId returned from SES for successful submissions. That'll be crucial to bounce handling (#4284), and in general is a Good Idea™ (cf. #4442).

[chadwhitacre]

Alright, MessageId stored in e45ba2b.

[rohitpaulk]

Looks good to me. I'm a bit confused as to why log_every has to be patched for the test, but that isn't really important compared to the purpose of this patch itself.

Waiting for Travis.

[chadwhitacre]

I'm a bit confused as to why log_every has to be patched for the test

Good guestion! That might be noise. 😶