Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Switch to Sentry for CSP #4542

Merged
merged 4 commits into from
Jul 12, 2017
Merged

Switch to Sentry for CSP #4542

merged 4 commits into from
Jul 12, 2017

Conversation

chadwhitacre
Copy link
Contributor

Closes #4526.

@chadwhitacre
Copy link
Contributor Author

Ready for review, @EdOverflow @rohitpaulk et al.

@rohitpaulk
Copy link
Contributor

rohitpaulk commented Jul 12, 2017 •
edited
Loading

Looks like report-uri is going to be deprecated in favour of report-to, because it sends one request for every violation. No popular browser has implemented report-to yet though, so I think this is safe to merge.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/report-uri (Link to report-to broken in MDN, bug filed)
github/secure_headers#269
https://wicg.github.io/reporting/
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/Xro1jnasnY0/rUbiEtbDBQAJ

@rohitpaulk
Copy link
Contributor

Ready when Travis is

@EdOverflow EdOverflow merged commit d7bde18 into master Jul 12, 2017
@EdOverflow EdOverflow deleted the sentry-csp branch July 12, 2017 20:00
@chadwhitacre chadwhitacre mentioned this pull request Jul 18, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EdOverflow EdOverflow EdOverflow approved these changes

Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chadwhitacre @rohitpaulk @EdOverflow