Present claimed packages as projects #4398

chadwhitacre · 2017-04-04T20:08:57Z

Part of #4305, follows on #4397.

Todo

redirect /on/npm/bar/ to /deadbeef/ when claimed
fix regression in project receiving charts: Present claimed packages as projects #4398 (comment) —done in 582af24

chadwhitacre · 2017-04-04T20:09:16Z

chadwhitacre · 2017-04-04T20:16:21Z

3347ae3 😍

chadwhitacre · 2017-04-08T10:00:40Z

Yesterday I started down a path of using Aspen typecasters to DRY up in a more general way. PR forthcoming against master for typecasting implementation, blocking this on that.

chadwhitacre · 2017-04-10T15:45:15Z

Alright, so we're looking at either implementing proper internal redirects, or serving package-projects on the same paths as regular projects after all.

The former is proving tricky (we either greatly complicate the website.algorithm, or we figure out how to rerun the entire algorithm). The latter should be fairly straightforward, though I guess that means further crowding our global project namespace w/ all of the npm namespace, putting more pressure on #4246.

chadwhitacre · 2017-04-10T15:55:18Z

I guess that means we need to try to name projects after the underlying package on-claim, falling back as with usernames.

chadwhitacre · 2017-04-10T17:09:36Z

Bumped remaining todos to #4404. Ready for review!

chadwhitacre · 2017-04-11T18:45:24Z

c34da4f or thereabouts breaks www/%team/charts.json.spt. Write a test for that and review other cases as well.

pid-89470 thread-140735094956800 (MainThread) Traceback (most recent call last):
pid-89470 thread-140735094956800 (MainThread)   File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/algorithm.py", line 288, in run
pid-89470 thread-140735094956800 (MainThread)     new_state = function(**deps.as_kwargs)
pid-89470 thread-140735094956800 (MainThread)   File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/aspen/algorithms/website.py", line 115, in get_response_for_resource
pid-89470 thread-140735094956800 (MainThread)     return {'response': resource.respond(state)}
pid-89470 thread-140735094956800 (MainThread)   File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/aspen/http/resource.py", line 59, in respond
pid-89470 thread-140735094956800 (MainThread)     content_type, body = super(Dynamic, self).respond(accept, state)
pid-89470 thread-140735094956800 (MainThread)   File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/aspen/simplates/__init__.py", line 169, in respond
pid-89470 thread-140735094956800 (MainThread)     exec(self.pages[1], context)
pid-89470 thread-140735094956800 (MainThread)   File "/Users/whit537/personal/gratipay/gratipay.com/www/%team/charts.json.spt", line 48, in <module>
pid-89470 thread-140735094956800 (MainThread)     """, (slug,), back_as=dict)
pid-89470 thread-140735094956800 (MainThread)   File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/postgres/__init__.py", line 548, in all
pid-89470 thread-140735094956800 (MainThread)     return cursor.all(sql, parameters)
pid-89470 thread-140735094956800 (MainThread)   File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/postgres/cursors.py", line 145, in all
pid-89470 thread-140735094956800 (MainThread)     self.execute(sql, parameters)
pid-89470 thread-140735094956800 (MainThread)   File "/Users/whit537/personal/gratipay/gratipay.com/env/lib/python2.7/site-packages/psycopg2/extras.py", line 223, in execute
pid-89470 thread-140735094956800 (MainThread)     return super(RealDictCursor, self).execute(query, vars)
pid-89470 thread-140735094956800 (MainThread) ProgrammingError: can't adapt type 'Team'

dowski · 2017-04-20T23:29:53Z

gratipay/exceptions.py

@@ -87,3 +87,6 @@ def __str__(self):
        return "Negative balance not allowed in this context."

 class NotWhitelisted(Exception): pass
+
+
+class OutOfOptions(Exception): pass


A clearer name or a docstring would help this Exception class.

Done in 3712318.

dowski · 2017-04-20T23:36:31Z

gratipay/models/package/__init__.py

@@ -1,6 +1,10 @@
 # -*- coding: utf-8 -*-


Can this whole change be merged with master so that changes in the previous PR are reflected here? It should make it easier to review.

Hopefully da0c3da helps?

dowski · 2017-04-21T02:08:10Z

gratipay/models/team/__init__.py

+
+    if team is None:
+        # Try to redirect to a Participant.
+        from gratipay.models.participant import Participant # avoid circular import


Open a new GH issue to refactor this so you don't have to lazy-import. Circular dependencies are a hassle.

Done: #4421.

chadwhitacre · 2017-04-24T14:57:23Z

Rebased, was 89202f8.

chadwhitacre · 2017-04-24T15:03:23Z

Rebasing, determined from #4397 (comment) that 757b498 and previous can be pushed off of here. The work starts at 8151f86.

chadwhitacre · 2017-04-24T15:42:17Z

Squashed to ease rebase, was 89202f8.

chadwhitacre · 2017-04-24T15:43:53Z

Not sure what I was thinking. Conflict resolution is effectively the same. Lessee here ...

chadwhitacre · 2017-04-24T21:21:34Z

Okay! Now to address review and todo ...

Since alice is a user we were getting redirects to /~alice.

chadwhitacre · 2017-04-24T21:57:41Z

Alright @dowski, another one on deck!

dowski

One minor thing, but overall looks good.

dowski · 2017-04-26T03:07:34Z

gratipay/models/package/__init__.py

-        return team
+            break
+        else:
+            raise OutOfOptions()


This code will never run, unless UUID4 is broken. I'd put my money on UUID4 and remove the else and the exception.

Done in 132eceb.

Includes: #4335 #4397 #4398 #4404 #4422 #4406 #4410 #4411 #4423

chadwhitacre changed the base branch from master to project/claim-packages-finish April 4, 2017 20:09

chadwhitacre mentioned this pull request Apr 4, 2017

Integrate initial package claiming PRs #4305

Merged

25 tasks

chadwhitacre force-pushed the project/claim-packages-view branch from 91d7d1b to 6f65eec Compare April 5, 2017 17:12

chadwhitacre mentioned this pull request Apr 6, 2017

Apply to Indie.vc gratipay/inside.gratipay.com#1034

Closed

chadwhitacre mentioned this pull request Apr 10, 2017

Edit claimed packages #4404

Merged

15 tasks

chadwhitacre force-pushed the project/claim-packages-finish branch from 757b498 to 404107c Compare April 17, 2017 12:07

dowski suggested changes Apr 21, 2017

View reviewed changes

dowski reviewed Apr 21, 2017

View reviewed changes

chadwhitacre force-pushed the project/claim-packages-finish branch from 9f9c87e to 1d42094 Compare April 24, 2017 14:56

chadwhitacre force-pushed the project/claim-packages-view branch from 89202f8 to df8e4ac Compare April 24, 2017 15:36

chadwhitacre force-pushed the project/claim-packages-view branch from 276d28d to ca01581 Compare April 24, 2017 15:42

Present claimed packages as projects

da0c3da

chadwhitacre force-pushed the project/claim-packages-view branch from ca01581 to da0c3da Compare April 24, 2017 21:21

chadwhitacre mentioned this pull request Apr 24, 2017

Do away with lazy imports #4421

Closed

chadwhitacre added 2 commits April 24, 2017 17:33

Document an exception

3712318

Actually test team URLs during browsing

f6eaaa0

Since alice is a user we were getting redirects to /~alice.

chadwhitacre added the Review label Apr 24, 2017

Fix up browse tests for teams

77d42b0

chadwhitacre force-pushed the project/claim-packages-view branch from 582af24 to 77d42b0 Compare April 25, 2017 00:00

dowski approved these changes Apr 26, 2017

View reviewed changes

chadwhitacre changed the base branch from project/claim-packages-finish to project/claim-packages April 26, 2017 08:51

Trust UUID4

132eceb

dowski merged commit f50cf4e into project/claim-packages Apr 27, 2017

chadwhitacre deleted the project/claim-packages-view branch April 27, 2017 08:00

chadwhitacre added a commit that referenced this pull request Apr 28, 2017

Checkpoint 2

771c40f

Includes: #4335 #4397 #4398 #4404 #4422 #4406 #4410 #4411 #4423

chadwhitacre added a commit that referenced this pull request Apr 28, 2017

Checkpoint 2

eb5921f

Includes: #4335 #4397 #4398 #4404 #4422 #4406 #4410 #4411 #4423

chadwhitacre added a commit that referenced this pull request May 5, 2017

Checkpoint 2

9898a38

Includes: #4335 #4397 #4398 #4404 #4422 #4406 #4410 #4411 #4423

chadwhitacre added a commit that referenced this pull request May 9, 2017

Checkpoint 2

24559cb

Includes: #4335 #4397 #4398 #4404 #4422 #4406 #4410 #4411 #4423

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Present claimed packages as projects #4398

Present claimed packages as projects #4398

chadwhitacre commented Apr 4, 2017 •

edited

Loading

chadwhitacre commented Apr 4, 2017

chadwhitacre commented Apr 4, 2017

chadwhitacre commented Apr 8, 2017

chadwhitacre commented Apr 10, 2017 •

edited

Loading

chadwhitacre commented Apr 10, 2017

chadwhitacre commented Apr 10, 2017

chadwhitacre commented Apr 11, 2017 •

edited

Loading

dowski Apr 20, 2017

chadwhitacre Apr 24, 2017

dowski Apr 20, 2017

chadwhitacre Apr 24, 2017

dowski Apr 21, 2017

chadwhitacre Apr 24, 2017

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

dowski left a comment

dowski Apr 26, 2017

chadwhitacre Apr 26, 2017

Present claimed packages as projects #4398

Present claimed packages as projects #4398

Conversation

chadwhitacre commented Apr 4, 2017 • edited Loading

Todo

chadwhitacre commented Apr 4, 2017

chadwhitacre commented Apr 4, 2017

chadwhitacre commented Apr 8, 2017

chadwhitacre commented Apr 10, 2017 • edited Loading

chadwhitacre commented Apr 10, 2017

chadwhitacre commented Apr 10, 2017

chadwhitacre commented Apr 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

chadwhitacre commented Apr 24, 2017

dowski left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chadwhitacre commented Apr 4, 2017 •

edited

Loading

chadwhitacre commented Apr 10, 2017 •

edited

Loading

chadwhitacre commented Apr 11, 2017 •

edited

Loading