Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Rip out READMEs after all #4211

Merged
merged 3 commits into from
Dec 2, 2016
Merged

Rip out READMEs after all #4211

merged 3 commits into from
Dec 2, 2016

Conversation

chadwhitacre
Copy link
Contributor

Post-#4151. READMEs are too much work to keep up with and keep secure, especially when we want to add 30+ more package managers.

@chadwhitacre chadwhitacre changed the title Rip our READMEs after all Rip out READMEs after all Nov 30, 2016
@chadwhitacre chadwhitacre mentioned this pull request Nov 30, 2016
23 tasks
@chadwhitacre
Copy link
Contributor Author

Ping @aandis etc. for review.

@aandis I think READMEs are too much trouble after all. 😞

@aandis
Copy link
Contributor

aandis commented Dec 1, 2016

meh. I kinda feel bad, so much work went into it. 😞 I am gonna review this tonight.

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Dec 1, 2016

Well, but think about all the work we're saving ourselves by not committing to maintaining and securing README wrappers for 30+ package managers. :-)

They're too much work to keep up with and keep secure, especially when
we want to add 30+ more package managers.
@aandis
Copy link
Contributor

aandis commented Dec 2, 2016

Rebased on master, previous head was 74c43e3

@aandis
Copy link
Contributor

aandis commented Dec 2, 2016

@whit537 this looks good to me. One minor improvement would be to define this here instead of passing it over and over

@chadwhitacre
Copy link
Contributor Author

One minor improvement would be to define this here instead of passing it over and over

@aandis The issue is that it depends on state we're loading from wireup, so we can't define it globally as we can with log. Do you see a way around that?

this looks good to me.

Cool. May I let you hit the merge button when you're ready? :-)

@aandis
Copy link
Contributor

aandis commented Dec 2, 2016

Do you see a way around that?

sentrified(func, env)?

@chadwhitacre
Copy link
Contributor Author

@aandis How about cb1a53f? :-)

@chadwhitacre
Copy link
Contributor Author

(We'll see if Travis likes it ...)

@aandis aandis merged commit 09e1c8e into master Dec 2, 2016
@aandis aandis deleted the rip-out-readmes branch December 2, 2016 20:00
@aandis
Copy link
Contributor

aandis commented Dec 2, 2016

@whit537 what's the next step in this? I'll try to find some time this weekend.

@chadwhitacre
Copy link
Contributor Author

Deployed!

@chadwhitacre
Copy link
Contributor Author

what's the next step in this?

This is part of the "Pay for any package on npm" project (#4148), but we need to land "Relax Open Work Requirement" (gratipay/inside.gratipay.com#432) first.

@chadwhitacre chadwhitacre mentioned this pull request May 3, 2017
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants