bring back the takes UI

[chadwhitacre]

⬑ #3994

← #4099 (diff)

Refactor the new takes/membership code now that #4023 and #4024 are merged into this new line of development.

• rebase once Cherry pick 4024 #4076 lands
• don't call get_take_for from set_take_for (use old_takes)
• deduplicate error handling between python and simplates
• rebase once Respect non-searchable users choice when doing a lookup #4090 lands
• prevent owner from joining a Team (new PR?)
• factor out a few other PRs ... test helpers #4092 *use* the new test helpers #4093 require docs #4094 update some python APIs #4099
• rebase once update some python APIs #4099 lands
• restrict the distributing page—bring back the takes UI #4077 (comment) —done in d39d411
• don't restrict the distributing page :) —bring back the takes UI #4077 (comment) —reverted in 1733e21
• back out the lookup.json l10n—done in 505c14f
• back out the admin bar l10n— bring back the takes UI #4077 (comment) —done in 064b88c
• cram the table into the layout—bring back the takes UI #4077 (comment)
• clean up sidebar—bring back the takes UI #4077 (comment)
• nicely prevent owners from adding ineligible members—bring back the takes UI #4077 (comment) —done in c0cf218 and 51d9739
• consider fixing test helper for Chrome 52—bring back the takes UI #4077 (comment) —done in 1866b96 2be3a87 aa5a093 and 68ac098

[chadwhitacre]

Page is barely loading! 😱

[chadwhitacre]

Yay! 😍

[chadwhitacre]

Alright, I migrated client-side tests to Splinter in #4079, and have inserted that into the PR chain. Ready to write some tests for this UI! :-)

[chadwhitacre]

#4076 is in, and I've rebased on master. Onward!

[chadwhitacre]

BLAM!!!!!!!!!!!!!!!!!!!

Adding members, tested ... 👍

[chadwhitacre]

As part of getting this to work, I made a couple other changes that should be separate PRs.

[chadwhitacre]

2af9e57 2378e26 f3dc415 could/should be cherry-picked into separate PRs.

[chadwhitacre]

Hmm ... a test failure to investigate. Perhaps related to PhantomJS vs. Chrome?

[chadwhitacre]

Okay! Travis is happy. 👍

Now to bring removing users, and then setting takes ...

[chadwhitacre]

ba81708 and 6d190c5 can go in a separate PR as well.

[chadwhitacre]

... aaaaaaaand 1ea1294. :)

[ghost]

You won't need lookup.json anymore? Otherwise, I can make the small adjustments we talked about (~ don't return the non-searchable users except in the case of an exact match).

[chadwhitacre]

You won't need the lookup.json anymore? Otherwise, I can make the small adjustments we talked about (~ don't return the non-searchable users except in the case of an exact match).

We should address that before going live with the rest of the work on this PR, yes. Wanna do that in a separate PR, and we can be sure to deploy that before landing this PR?

[ghost]

I'm getting a bunch of errors while trying to run only one test. I'll finish the tests and make the PR after lunch :-)

[chadwhitacre]

I'm getting a bunch of errors while trying to run only one test. I'll finish the tests and make the PR after lunch :-)

If you start a PR with the broken code, we can maybe help debug. :)

[chadwhitacre]

(You could be hitting problems introduced by #4079.)

[ghost]

No broken code, but I think I'll add a Makefile rule to be able to only run a batch of tests (pytest's -k option).
The PR is alive in #4090!

[chadwhitacre]

I think I'll add a Makefile rule to be able to only run a batch of tests (pytest's -k option).

Go for it. I have this in my .profile:

alias envtest="honcho run -e defaults.env,local.env,tests/test.env,tests/local.env py.test"

So I run tests like this:

envtest tests/ttw/test_foo.py -k test_foo_

[chadwhitacre]

💃