This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
stop Python-interpolating payday.sql #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Python string interpolation on the payday.sql file introduces complexity that leads to bugs. The one I hit was using '%' for interpolation in a Postgres RAISES clause: it would've had to be escaped to make it through the Python interpolation.
|
Ready for review @rorepo @rohitpaulk et al. |
|
Code looks good, waiting for green... |
rohitpaulk
added a commit
that referenced
this pull request
Sep 14, 2015
stop Python-interpolating payday.sql
|
Thanks @rohitpaulk! 💃 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Python string interpolation on the
payday.sqlfile introduces complexity that leads to bugs. The one I hit was using%for interpolation in a PostgresRAISESclause: it would've had to be escaped to make it through the Python interpolation.I cherry-picked this from 364d066 in #3653.
See reference in #3780 (comment).