This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporates #3403. |
Where are all the places where the Python API interacts with the |
Here's what I can find:
|
Here's the behavior this PR should implement:
|
Merged
The max tip limit interacts with the |
This PR can archive the |
chadwhitacre
force-pushed
the
turn-off-tipping
branch
from
May 12, 2015 20:52
53cfe80
to
aed5da6
Compare
Here are the parts of the UI that touch
In other words, quite a bit of it, as well as quite a bit of the test suite. Hmm ... |
Closed
chadwhitacre
force-pushed
the
turn-off-tipping
branch
from
May 12, 2015 21:47
aed5da6
to
36ae25e
Compare
Revised scope for this PR: let's reduce our surface area for changes to Participant. |
Tests marked xfail, bring them back once we have tipping back on Teams.
Disentangles `number` from `tips`
We'll bring back something comparable down the line.
We no longer have giving attached to a participant
chadwhitacre
force-pushed
the
turn-off-tipping
branch
from
May 12, 2015 22:22
52dd150
to
9213b68
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn off tipping in the UI, the JSON API, and the Python API. After this PR, there should be no more code using theReduce the surface area for changes by removing code we won't need under the Teams system.tips
table.