Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Take over clear balanced_account_uri on absorbed participant. #1903

Closed
wants to merge 2 commits into from

Conversation

zbynekwinkler
Copy link
Contributor

Fixes #1854.

@zbynekwinkler
Copy link
Contributor Author

Should we also fix the database?

select count(*) 
from participants 
where balanced_account_uri is not null 
and username in (select archived_as from absorptions);

returns

 count 
-------
    38
(1 row)

What worries me is that we are loosing data by this since we do not log (yet) the balanced_account_uri 😟

@chadwhitacre
Copy link
Contributor

@zwn We do have the data in old backups (worst case scenario).

@chadwhitacre
Copy link
Contributor

What if the absorbing account has no balance_account_uri? Do we want to copy over the old balance_account_uri? That's what #818 #941 is about.

@zbynekwinkler
Copy link
Contributor Author

What if the absorbing account has no balance_account_uri? Do we want to copy over the old balance_account_uri? That's what #941 is about.

I don't know how the balanced api works so I don't know if this is the way to bring over the things registered with them.

@chadwhitacre
Copy link
Contributor

@zwn I think we should close this, because it depends on our strategy wrt take_over and that's far from decided yet (#1948).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

take_over should clear credit card on file
2 participants