-
Notifications
You must be signed in to change notification settings - Fork 308
build a "gittip" button / widget a la facebook like, tweet, google +1, etc. #41
Comments
See also #21, which is a dynamic PNG (this is a javascript widget). |
From @timothyfcook:
|
This needs to be an iframe that hits tip.json. |
@d0ugal, we good on security here? |
If its all in an iframe it should be fine, I guess your only risk is clickjacking, but I don't know much about that to be honest. I've not actually read the code though, I could have a cursory read over the next few days if that helps. |
I'm not too worried about it as it just links to your profile. No POST from chad On Fri, Jul 13, 2012 at 4:11 PM, Dougal Matthews <
|
One issue: needs closing </iframe> tag to work in my Jekyll layout. Other than that, great start! See it at the bottom of http://chrismdp.github.com :) |
I guess Jekyll wants this. Let's help folks out by putting it in the default embed code suggested.
Will the iframe work on, say, a github readme that uses markdown? What about rst? |
So, think I'm missing something. What is the purpose of the iframe if all it does is act like a link? Why don't we just use a button/anchor? |
Hmm, nevermind. I miss understood - I see its so the button can change and perform tips. It looks like its not working in @chrismdp's site. It always just shows "Gittip" for me when logged in or not. |
Odd -- appears to be working for me (at least, I can see "You!" at the bottom of my blog when signed in...) |
Heh, ok. It's just me being slow again. It is working. False alarm. |
This should be doable with the tip.json API.
Examples
https://dev.twitter.com/docs/tweet-button
http://www.google.com/webmasters/+1/button/
http://developers.facebook.com/docs/reference/plugins/like/
The text was updated successfully, but these errors were encountered: