Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

build a "gittip" button / widget a la facebook like, tweet, google +1, etc. #41

Closed
chadwhitacre opened this issue Jun 12, 2012 · 12 comments

Comments

@chadwhitacre
Copy link
Contributor

This should be doable with the tip.json API.

Examples

https://dev.twitter.com/docs/tweet-button
http://www.google.com/webmasters/+1/button/
http://developers.facebook.com/docs/reference/plugins/like/

@chadwhitacre
Copy link
Contributor Author

See also #21, which is a dynamic PNG (this is a javascript widget).

chadwhitacre added a commit that referenced this issue Jun 15, 2012
I've got someone asking to help with building a widget (#21, #41). I
believe this JSON API will enable that.
@chadwhitacre
Copy link
Contributor Author

From @timothyfcook:

For confident do-gooders out there who are sharing their work with others (for free), we should enable them to solicit Tips on their personal sites via a Gittip widget; some sort of embedded Gittip-branded box.

Essentially, it is the guitar case open in front of the street musician.

This Gittip-box would appear on people's blogs, personal sites, project sites, etc. in order to solicit Gittips. This will help spread the reaches of Gittip to the outer edges of the interweb!

@chadwhitacre
Copy link
Contributor Author

This needs to be an iframe that hits tip.json.

@chadwhitacre
Copy link
Contributor Author

@d0ugal, we good on security here?

@d0ugal
Copy link

d0ugal commented Jul 13, 2012

If its all in an iframe it should be fine, I guess your only risk is clickjacking, but I don't know much about that to be honest.

I've not actually read the code though, I could have a cursory read over the next few days if that helps.

@chadwhitacre
Copy link
Contributor Author

I'm not too worried about it as it just links to your profile. No POST from
the iframe. More eyes never hurts.

chad

On Fri, Jul 13, 2012 at 4:11 PM, Dougal Matthews <
[email protected]

wrote:

If its all in an iframe it should be fine, I guess your only risk is
clickjacking, but I don't know much about that to be honest.

I've not actually read the code though, I could have a cursory read over
the next few days if that helps.


Reply to this email directly or view it on GitHub:
https://github.com/whit537/www.gittip.com/issues/41#issuecomment-6973992

@chrismdp
Copy link

One issue: needs closing </iframe> tag to work in my Jekyll layout.

Other than that, great start! See it at the bottom of http://chrismdp.github.com :)

chadwhitacre added a commit that referenced this issue Jul 13, 2012
I guess Jekyll wants this. Let's help folks out by putting it in the
default embed code suggested.
@akoumjian
Copy link

Will the iframe work on, say, a github readme that uses markdown? What about rst?

@d0ugal
Copy link

d0ugal commented Jul 15, 2012

So, think I'm missing something. What is the purpose of the iframe if all it does is act like a link? Why don't we just use a button/anchor?

@d0ugal
Copy link

d0ugal commented Jul 16, 2012

Hmm, nevermind. I miss understood - I see its so the button can change and perform tips. It looks like its not working in @chrismdp's site. It always just shows "Gittip" for me when logged in or not.

@chrismdp
Copy link

Odd -- appears to be working for me (at least, I can see "You!" at the bottom of my blog when signed in...)

@d0ugal
Copy link

d0ugal commented Jul 16, 2012

Heh, ok. It's just me being slow again. It is working. False alarm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants