shouldn't archived users be unclaimed?

[chadwhitacre]

Right now when we archive users during take_over we leave their claimed_time alone. This results in orphan accounts like https://www.gittip.com/74e0d6d7b20a/. Right now we have 863 of these. Why not set claimed_time to NULL during take_over archiving? Because we don't want to lose some info or something?

[chadwhitacre]

Seems like what we want to do is start using add_event to record the old claimed_time in that case? Actually, we have an add_event in set_as_claimed, so we already have that info there. We don't need the claimed time in the orphan account.

[chadwhitacre]

Another 10,374 accounts are in the absorptions table and have claimed_time null.

[chadwhitacre]

They result in a 404: https://www.gittip.com/c94df7c6b3c6/.

[chadwhitacre]

Presumably from here.

[chadwhitacre]

So let's see if we have claimed events for the 863 orphans with claimed_times.

[chadwhitacre]

We do! This returns 863 results:

select * from events
where payload->>'action'='claim'
and (payload->>'id')::bigint in (
    select p.id from participants p
    join absorptions a on p.username = a.archived_as
    where claimed_time is not null
);

[chadwhitacre]

So we can set claimed_time to NULL for the accounts in question.

[chadwhitacre]

And then we can set claimed_time to NULL during archiving, for both take_over and account cancelation.