Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

update address info in card tokenization #2446

Closed
chadwhitacre opened this issue May 29, 2014 · 7 comments
Closed

update address info in card tokenization #2446

chadwhitacre opened this issue May 29, 2014 · 7 comments

Comments

@chadwhitacre
Copy link
Contributor

Reticketed from #2372 (comment).

The original tokenization payload you sent through looks like

{
...
      "address": {
        "state": "VD",
        "postal_code": "1807",
        "line1": "<REMOVED>"
      }
...
}

what you want it to look like would be (documentation)

{
...
            "address": {
                "city": null, 
                "country_code": "CHE", 
                "line1": "<REMOVED>", 
                "line2": null, 
                "postal_code": "1807", 
                "state": "VD"
            }, 
...
}

looks like the country code field is the only thing missing. alternatively you can omit the address data entirely. i'm not sure if that would increase the likelyhood of verifying the card but i do think it will work better than passing (inadvertently) incorrect address data. maybe balanced should not default the country code to USA as well.

@seanlinsley
Copy link
Contributor

Leaving this open for now, to discuss whether we still need to send up address info as part of meta.

@chadwhitacre
Copy link
Contributor Author

@seanlinsley The issue is that we pull info out of meta when repopulating the form. If we change that class around then we would want to either migrate the address to the new location for all old accounts, or write the class to support both access patterns.

@seanlinsley
Copy link
Contributor

Going through the code... can we delete the Stripe stuff already?

@seanlinsley
Copy link
Contributor

@whit537 to ensure that I do the migration correctly, could you provide an anonymized JSON dump for a CC and bank account from Balanced that use the old scheme(s)?

@chadwhitacre
Copy link
Contributor Author

[C]an we delete the Stripe stuff already?

That's #173. We have one participant still on Stripe, because they fell through the cracks when migrating data to Balanced. We charged them on Stripe as recently as this last payday.

@chadwhitacre
Copy link
Contributor Author

Closing as stalled.

@chadwhitacre
Copy link
Contributor Author

Blech, sorry. Meant that for #2450.

@chadwhitacre chadwhitacre reopened this Aug 20, 2014
@Changaco Changaco self-assigned this Mar 12, 2015
Changaco added a commit that referenced this issue Mar 24, 2015
Changaco added a commit that referenced this issue Mar 24, 2015
Changaco added a commit that referenced this issue Mar 24, 2015
Changaco added a commit that referenced this issue Mar 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants