Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple DTS fixes + CI adjustment #88

Merged
merged 10 commits into from
Sep 30, 2021
Merged

multiple DTS fixes + CI adjustment #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
beffe9f
CI: report only numbers (too many warnings to show in github)
okias Sep 18, 2021
92c7996
FIXUP: mfd: Add binding for Cypress CG7153AM Embedded Controller
okias Sep 18, 2021
2d74c46
FIXUP: chagall: add cypress,cg7153am compatible
okias Sep 18, 2021
906bc37
FIXUP: p4wifi typos etc.
okias Sep 19, 2021
af30691
FIXUP: glide: fix typo, comment not impl. VDD LVSIO
okias Sep 19, 2021
2ced8af
FIXUP: ARM: tegra: glide: comment otg-vbus inside max8922 node
okias Sep 27, 2021
f0da293
FIXUP: tegra20: glide: led naming & drop invalid default trig
okias Sep 29, 2021
49664a9
FIXUP: TF700T display-panel -> panel
okias Sep 30, 2021
11ea8e8
FIXUP: Ideatab: add 3v3sys regulator to the PWM backlight
okias Sep 30, 2021
9532d2d
FIXUP: ideatab -> supress warning
okias Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,20 @@ jobs:
- name: Evaluate warnings
run: |
warn=$(wc -l warn.log| cut -f1 -d" ")
cat warn.log
echo ":: warnings: $warn"
if [ "$warn" -gt "0" ]; then
cat warn.log
echo "::warning :: $warn warnings"
fi

- name: Evaluate critical warnings
run: |
grep -v "failed to match any schema with compatible:" warn.log > warn_crit.log
grep -v "failed to match any schema with compatible:" warn.log > warn_crit.log || exit 0
warn_crit=$(wc -l warn_crit.log| cut -f1 -d" ")
sed -i "s/^/::warning ::/" warn_crit.log
cat warn_crit.log
echo ":: warnings: $warn_crit"
if [ "$warn_crit" -gt "0" ]; then
cat warn_crit.log
echo "::warning :: $warn_crit critical warnings"
fi
exit 1
- name: Evaluate success
run: |
if [ -f status ]; then
Expand All @@ -145,5 +149,8 @@ jobs:
make -j8 dt_binding_check 2> >(tee warn.log >&2) > /dev/null
- name: Evaluate warnings
run: |
sed -i "s/^/::warning ::/" warn.log
cat warn.log
warn=$(wc -l warn.log| cut -f1 -d" ")
if [ "$warn" -gt "0" ]; then
cat warn.log
echo "::warning :: $warn warnings"
fi
15 changes: 9 additions & 6 deletions Documentation/devicetree/bindings/mfd/cypress,cg7153am.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
$id: http://devicetree.org/schemas/mfd/cypress,cg7153am.yaml#
Expand All @@ -15,10 +15,13 @@ description: |

properties:
compatible:
items:
- enum:
- pegatron,chagall-ec # Pegatron Chagall tablet device
- const: cypress,cg7153am
oneOf:
- items:
- enum:
- pegatron,chagall-ec # Pegatron Chagall tablet device
- const: cypress,cg7153am
- items:
const: cypress,cg7153am

reg:
maxItems: 1
Expand All @@ -41,7 +44,7 @@ examples:
#size-cells = <0>;

embedded-controller@10 {
compatible = "pegatron,chagall-ec";
compatible = "pegatron,chagall-ec", "cypress,cg7153am";
reg = <0x10>;

monitored-battery = <&battery>;
Expand Down
14 changes: 8 additions & 6 deletions arch/arm/boot/dts/tegra20-glide.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,11 @@
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(D, 7) IRQ_TYPE_LEVEL_LOW>;

avdd-supply = <&tsp_avdd>;
lvsio-supply = <&tsp_lvsio>;
vdda-supply = <&tsp_avdd>;
/* VDD LVSIO (level shifter) is not yet
* implemented in maxtouch driver
* TODO: lvsio-supply = <&tsp_lvsio>;
*/
vdd-supply = <&tsp_vdd>;
};
};
Expand Down Expand Up @@ -883,7 +886,7 @@
* (specified as uok since USB is detected)
*/

charger_supply: otg-vbus {};
// charger_supply: otg-vbus {}; // not implemented yet
};

i2c-7 {
Expand Down Expand Up @@ -1226,7 +1229,7 @@
leds {
compatible = "gpio-leds";

kbd {
led-kbd {
label = "Keyboard backlight";
gpios = <&gpio TEGRA_GPIO(L, 5) GPIO_ACTIVE_HIGH>;
/*
Expand All @@ -1237,7 +1240,6 @@
* echo gpio > /sys/class/leds/Keyboard\ backlight/trigger
* echo 179 > /sys/class/leds/Keyboard\ backlight/gpio
*/
linux,default-trigger = "gpio";
default-state = "off";
};
};
Expand Down Expand Up @@ -1728,7 +1730,7 @@
* this thing is so slow!
*/
regulator-enable-ramp-delay = <350000>;
vin-supply = <&charger_supply>;
// vin-supply = <&charger_supply>;
};

gps_en: regulator-gps {
Expand Down
7 changes: 5 additions & 2 deletions arch/arm/boot/dts/tegra20-p4wifi.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(D, 4) IRQ_TYPE_LEVEL_LOW>;

reset-gpio = <&gpio TEGRA_GPIO(D, 3) GPIO_ACTIVE_LOW>;
reset-gpios = <&gpio TEGRA_GPIO(D, 3) GPIO_ACTIVE_LOW>;

atmel,wakeup-method = <ATMEL_MXT_WAKEUP_I2C_SCL>;
};
Expand Down Expand Up @@ -596,7 +596,7 @@
wlf,ldo1ena = <&gpio TEGRA_GPIO(X, 5) GPIO_ACTIVE_HIGH>;
wlf,gpio-cfg = <0xA101 0 0 0 0 0 0 0 0 0 0>;

lineout1-se;
wlf,lineout1-se;

// TODO: supplies not tested
AVDD1-supply = <&sm2_reg>;
Expand Down Expand Up @@ -1061,8 +1061,11 @@
broken-cd;
no-1-8-v;
non-removable;
#address-cells = <1>;
#size-cells = <0>;

brcmf: wifi@1 {
reg = <1>;
compatible = "brcm,bcm4329-fmac";
};
};
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/tegra30-asus-tf700t.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
* Panasonic VVX10F004B00 or HYDIS HV101WU1-1E1
* LCD SuperIPS+ Full HD panel.
*/
display-panel@1 {
panel@1 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix a warning? A500, N7 and all other transformers use display-panel name, they should also produce the warning then, shouldn't they?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't fix directly any warning, but since nodes containing display panel are usually named panel@ I renamed the node to match that schematic. I could keep it as display-panel and alter yaml Doc to reflect that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, no need to change it.

compatible = "panasonic,vvx10f004b00";
reg = <1>;

Expand Down
7 changes: 7 additions & 0 deletions arch/arm/boot/dts/tegra30-lenovo-ideatab-a2109a.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,6 +1417,7 @@

enable-gpios = <&gpio TEGRA_GPIO(H, 3) GPIO_ACTIVE_HIGH>;
pwms = <&pwm 0 100000>;
power-supply = <&vdd_3v3_sys>;

brightness-levels = <
0 6 6 6 6 6 6 7
Expand Down Expand Up @@ -1559,6 +1560,12 @@
vfront-porch = <15>;
vback-porch = <15>;
};

/* dummy port, remove before upstreaming! */
port {
endpoint {
};
};
};

vdd_5v0_sys: regulator-5v0 {
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/tegra30-pegatron-chagall.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,7 @@
clock-frequency = <400000>;

embedded-controller@10 {
compatible = "pegatron,chagall-ec";
compatible = "pegatron,chagall-ec", "cypress,cg7153am";
reg = <0x10>;

monitored-battery = <&battery>;
Expand Down