Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add success status check for registration events in NATs #72

Closed
mango-habanero opened this issue May 28, 2023 · 0 comments · Fixed by #73
Closed

Add success status check for registration events in NATs #72

mango-habanero opened this issue May 28, 2023 · 0 comments · Fixed by #73
Assignees
@mango-habanero
Labels
bug Something isn't working

Comments

@mango-habanero
Copy link
Contributor

The current registration event handler in ussd assumes that an event from the REGISTER stream will always be successful this is wrong.
Add a check for the transaction status before marking it as activated on the chain and proceeding with activation on ussd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mango-habanero mango-habanero

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(nats): Adds status checks for failed registration events grassrootseconomics/cic-ussd
1 participant
@mango-habanero