Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add me to champions #694

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Add me to champions #694

merged 2 commits into from
Mar 5, 2020

Conversation

binaryseed
Copy link
Collaborator

No description provided.

@@ -754,6 +756,8 @@ input DogInput {

## 💡 5. One Of (Tagged Union)

**Champion:** @binaryseed
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjie Do you want to join the champion list for this one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and added you here instead of me, even though I'm a fan of this idea as well :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! Thanks; I thought I'd done whatever was necessary back in December - seems I missed adding myself 🤦‍♂️

#627 (comment)

@binaryseed binaryseed merged commit 6671989 into master Mar 5, 2020
@binaryseed binaryseed deleted the binaryseed-champion branch March 5, 2020 18:33
@leebyron leebyron added the 📣 RFC document PR creates or changes document inside "rfc" folder label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📣 RFC document PR creates or changes document inside "rfc" folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants