Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input unions: switch to reference-style links #661

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

benjie
Copy link
Member

@benjie benjie commented Dec 17, 2019

As discussed with @binaryseed here: #627 (comment)

Makes it a lot easier to add cross-references (no longer have to copy/paste the whole link) and makes it a lot easier to read the raw markdown (the tables in particular). Also means if we change a heading's text we only need to fix the URL in one place.

Thanks to these Vim commands:

:%s/\v\(#-([a-n])-[^)]+\)/[criteria-\1]/g

:%s/\v\(#-([1-5])-[^)]+\)/[solution-\1]/g
@binaryseed
Copy link
Collaborator

Awesome, I've never seen this before but it's great!

@binaryseed binaryseed merged commit f81b8ec into graphql:master Dec 17, 2019
@benjie benjie deleted the link-references branch January 10, 2020 13:52
@leebyron leebyron added the 📣 RFC document PR creates or changes document inside "rfc" folder label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📣 RFC document PR creates or changes document inside "rfc" folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants