Allow union type begining pipe #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the type definition syntax to the GraphQL specification.
|
@robzhu @IvanGoncharov I update the PR here. |
|
Can you please post a screenshot of the rendered spec document? |
|
Also, please don't forget to update the language grammar appendix |
|
|
|
Thanks! As I expected it's not rendering correctly. Notice other optional tokens have an opt subtext after them. This appears to require the literal character |
|
Do you think this form is weird or challenging to read? (open to advice) Otherwise a change to spec-md will be required to allow for optional terminals |
|
@leebyron I'm already working on a PR on |
leebyron
force-pushed
the
rfc-idl
branch
3 times, most recently
from
4bacab6
to
4d63721
Compare
leebyron
added a commit
that referenced
this pull request
Dec 4, 2017
|
I've merged this into the RFC in #90 🥇 |
leebyron
added a commit
that referenced
this pull request
Dec 6, 2017
leebyron
added a commit
that referenced
this pull request
Dec 19, 2017
leebyron
added a commit
that referenced
this pull request
Dec 21, 2017
leebyron
added a commit
that referenced
this pull request
Dec 21, 2017
leebyron
added a commit
that referenced
this pull request
Dec 22, 2017
10 tasks
leebyron
added a commit
that referenced
this pull request
Feb 8, 2018
leebyron
added a commit
that referenced
this pull request
Feb 8, 2018
* [RFC] GraphQL IDL additions This adds the type definition syntax to the GraphQL specification. * Add directives to all schema definition forms * expose more in example directive * Include more directive locations * Include deprecated directive * Note on omission of schema definition * Explicit ObjectTypeExtension grammar to support extending without adding fields * Ensure directives cannot reference variables in SDL * grammar * Remove duplicate EnumValue * First class descriptions * Minor wording change about markdown and TSL -> SDL * Add validation rule that executable documents cannot include SDL * Move extend keyword * Order of sections * Move language definitions into Type System section * Fix type reference header and comments * Add more examples of descriptions * Grammar * Include optional leading bar for unions & directive locations. Merging and closing #323 * Allow partial definitions (as @OlegIlyenko suggests) while legitimizing the use case by allowing type extensions for all type kinds, allowing at least the addition of new directives to any existing type. * Consistent plural usage in grammar nt rules * Remove ambiguous "may not" and explicitly state objects may implement interfaces via extensions * Extract ExecutableDefinition into a separate gramatical rule * Address review from @vergenzt * Use `&` to separate implemented interfaces, simplify grammar definitions * Fix reference in grammar summary * Fix reference to UnionMemberTypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the PR onto this branch
#320