Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note above variables to Values of Correct Type rule #1113

Closed

Conversation

yaacovCR
Copy link
Contributor

Thought to add an explicit note emerged from a discussion about @oneOf.

See benjie#1 (comment)

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 6fb00f4
🔍 Latest deploy log https://app.netlify.com/sites/graphql-spec-draft/deploys/66f3104cd8ea6e00089c48dd
😎 Deploy Preview https://deploy-preview-1113--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benjie
Copy link
Member

benjie commented Oct 17, 2024

I've taken a slightly different approach to this here: #1118; what do you think?

@yaacovCR
Copy link
Contributor Author

I've taken a slightly different approach to this here: #1118; what do you think?

Looks good to me. Closing in favor of #1118.

@yaacovCR yaacovCR closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants