Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the URL limit for GET operations #257

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

tazsingh
Copy link
Contributor

@tazsingh tazsingh commented Aug 21, 2023

Some CDNs (such as Cloudfront) do not support caching over POST. Thus, it's dramatically easier to hit the URL limit when sending variables over a query string.

I've added a paragraph to mention utilizing the POST body as an option for this or a HTTP header. I've personally used a X-GQLVARS header. Happy to include that naming here or leave it to the implementer on what to use

As I opened this document, my Grammarly extension corrected wording in some places. I've fixed them as the extension recommended, however I'm also happy to revert those changes and focus solely on the URL limit.

Note: I'm also creating this PR in order to sign the EasyCLA to participate in GraphQL Foundation meetings

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Taz! In future please send grammar/editorial fixes in a separate PR so they can be reviewed independently.

@benjie benjie merged commit 4db4e50 into graphql:main Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants