-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include kind in the types #4222
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
An issue here is that we are still missing fields/interfaces in that root type position, and doesn't seem to make sense to duplicate those... Alternative in #4224 is not workable yet. |
@yaacovCR not sure what you mean 😅 |
graphql-js/src/utilities/getIntrospectionQuery.ts Lines 227 to 234 in 45e28a5
The full correct type needs more than the kind |
@yaacovCR that is incorrect, the type for root-types is the following
|
Supersedes #3910
Fixes #3909
Fixes #3409
This puts the Selection-set in line with the expected type