Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include kind in the types #4222

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Include kind in the types #4222

merged 1 commit into from
Oct 11, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Oct 10, 2024

Supersedes #3910
Fixes #3909
Fixes #3409

This puts the Selection-set in line with the expected type

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner October 10, 2024 10:14
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 98fc85f
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6707a8efb9545900087ac4d9
😎 Deploy Preview https://deploy-preview-4222--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@JoviDeCroock JoviDeCroock added the PR: bug fix 🐞 requires increase of "patch" version number label Oct 11, 2024
@yaacovCR
Copy link
Contributor

An issue here is that we are still missing fields/interfaces in that root type position, and doesn't seem to make sense to duplicate those...

Alternative in #4224 is not workable yet.

@JoviDeCroock
Copy link
Member Author

@yaacovCR not sure what you mean 😅

@yaacovCR
Copy link
Contributor

yaacovCR commented Oct 11, 2024

export interface IntrospectionObjectType {
readonly kind: 'OBJECT';
readonly name: string;
readonly description?: Maybe<string>;
readonly fields: ReadonlyArray<IntrospectionField>;
readonly interfaces: ReadonlyArray<
IntrospectionNamedTypeRef<IntrospectionInterfaceType>
>;

The full correct type needs more than the kind

@JoviDeCroock
Copy link
Member Author

@yaacovCR that is incorrect, the type for root-types is the following

export interface IntrospectionNamedTypeRef<

@JoviDeCroock JoviDeCroock merged commit 6a379a5 into main Oct 11, 2024
35 checks passed
@JoviDeCroock JoviDeCroock deleted the fix-introspeciton-type branch October 13, 2024 14:34
JoviDeCroock added a commit that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants