Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Schema Coordinates #3807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Dec 29, 2022

#3044 rebased on main.

@leebyron comments from original PR:

Implements graphql/graphql-spec#794

Adds:

  • DOT punctuator in lexer
  • Improvements to lexer errors around misuse of .
  • Minor improvement to parser core which simplified this addition
  • SchemaCoordinate node and isSchemaCoodinate() predicate
  • Support in print() and visit()
  • Added function parseSchemaCoordinate() since it is a parser entry point.
  • Added function resolveSchemaCoordinate() and resolveASTSchemeCoordinate() which implement the semantics (name mirrored from buildASTSchema) as well as the return type GraphQLSchemaElement

@netlify
Copy link

netlify bot commented Dec 29, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 9fc6c0b
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/672b539c841d760008735195
😎 Deploy Preview https://deploy-preview-3807--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR added spec RFC Implementation of a proposed change to the GraphQL specification PR: feature 🚀 requires increase of "minor" version number labels Dec 29, 2022
@yaacovCR yaacovCR changed the title Schema Coordinates RFC: Schema Coordinates Jan 2, 2023
@yaacovCR yaacovCR force-pushed the schema-coordinates-rebased branch 3 times, most recently from 33c5916 to 1dafb51 Compare February 6, 2023 12:33
@yaacovCR yaacovCR force-pushed the schema-coordinates-rebased branch 2 times, most recently from e5ad1de to 75b9bd1 Compare May 31, 2023 11:06
@yaacovCR yaacovCR requested a review from a team as a code owner August 22, 2024 19:13
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Aug 22, 2024
yaacovCR added a commit that referenced this pull request Sep 4, 2024
extracted from @leebyron 's excellent #3807

will reduce that diff
@yaacovCR yaacovCR force-pushed the schema-coordinates-rebased branch 3 times, most recently from 2c3466e to 923f6d3 Compare September 11, 2024 15:16
Implements graphql/graphql-spec#794

Adds:

* DOT punctuator in lexer
* Improvements to lexer errors around misuse of `.`
* Minor improvement to parser core which simplified this addition
* `SchemaCoordinate` node and `isSchemaCoodinate()` predicate
* Support in `print()` and `visit()`
* Added function `parseSchemaCoordinate()` since it is a parser entry point.
* Added function `resolveSchemaCoordinate()` and `resolveASTSchemaCoordinate()` which implement the semantics (name mirrored from `buildASTSchema`) as well as the return type `ResolvedSchemaElement`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number spec RFC Implementation of a proposed change to the GraphQL specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants