-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KnownOperationTypes rule #3601
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
This comment has been minimized.
This comment has been minimized.
@yaacovCR The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
36163fb
to
304cef6
Compare
Neat, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 👍
So let's wait for stage2 to merge it.
Personally, I'm for fast-forwarding it to stage2 the next wg.
For the sake of the record, the spec PR is now graphql/graphql-spec#955 and is scheduled for discussion on Thursday. |
This comment was marked as outdated.
This comment was marked as outdated.
b3cc8f4
to
9797987
Compare
We're back to (an updated): I'm happy to continue to champion this at the WG unless someone else would like to take it on. |
New Spec PR: graphql/graphql-spec#1098
Old Spec PR: graphql/graphql-spec#947
Original issue raised by @benjaminjkraft : #3592