Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KnownOperationTypes rule #3601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented May 20, 2022

New Spec PR: graphql/graphql-spec#1098
Old Spec PR: graphql/graphql-spec#947
Original issue raised by @benjaminjkraft : #3592

@netlify
Copy link

netlify bot commented May 20, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 9797987
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/670ecbdef3f674000855b822
😎 Deploy Preview https://deploy-preview-3601--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yaacovCR yaacovCR added the spec RFC Implementation of a proposed change to the GraphQL specification label May 20, 2022
@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR

This comment has been minimized.

@github-actions
Copy link

@github-actions publish-pr-on-npm

@yaacovCR The latest changes of this PR are available on NPM as
graphql@17.0.0-alpha.1.canary.pr.3601.9a812ce71ad05c9dc089b40129f8295ca733e108
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-3601

@benjaminjkraft
Copy link

Neat, thanks!

Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍
So let's wait for stage2 to merge it.
Personally, I'm for fast-forwarding it to stage2 the next wg.

@benjaminjkraft
Copy link

For the sake of the record, the spec PR is now graphql/graphql-spec#955 and is scheduled for discussion on Thursday.

@yaacovCR

This comment was marked as outdated.

@benjie
Copy link
Member

benjie commented Oct 18, 2024

We're back to (an updated):

I'm happy to continue to champion this at the WG unless someone else would like to take it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec RFC Implementation of a proposed change to the GraphQL specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants