ci: disable Codecov and measure test coverage on every run #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
Motivation: codecov fails from time to time creating false alarms for our CI. For example, https://github.com/graphql/graphql-js/runs/6158401816?check_suite_focus=true
IvanGoncharov
force-pushed
the
pr_branch
branch
from
6e034fd to
9118388
Compare
|
@IvanGoncharov i don't know if c8 has a watch option, I couldn't find one -- preserving a testonly script without c8 is helpful to just throw on --watch on the command line. Or, maybe we could separately add a testonly:watch script? |
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 1, 2022
Refines graphql#3548. See graphql#3548 (comment)
Merged
IvanGoncharov
pushed a commit
that referenced
this pull request
May 2, 2022
Refines #3548. See #3548 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: codecov fails from time to time creating false alarms for
our CI. For example, https://github.com/graphql/graphql-js/runs/6158401816?check_suite_focus=true