Move call site for assertValidExecutionArguments #3297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacovCR
force-pushed
the
move-assert-valid
branch
from
a8a4b0c
to
58ee997
Compare
yaacovCR
force-pushed
the
execute-subscription
branch
2 times, most recently
from
c4263aa
to
289700a
Compare
yaacovCR
force-pushed
the
move-assert-valid
branch
2 times, most recently
from
c15d35c
to
a281cae
Compare
yaacovCR
force-pushed
the
execute-subscription
branch
from
289700a
to
b27058a
Compare
yaacovCR
force-pushed
the
move-assert-valid
branch
from
a281cae
to
47ba1af
Compare
yaacovCR
force-pushed
the
execute-subscription
branch
from
b27058a
to
2f97582
Compare
yaacovCR
force-pushed
the
move-assert-valid
branch
from
47ba1af
to
40e0200
Compare
yaacovCR
force-pushed
the
execute-subscription
branch
from
2f97582
to
10ccfea
Compare
The function is used only by `buildExecutionContext` and can be called there rather than exported
yaacovCR
force-pushed
the
move-assert-valid
branch
from
40e0200
to
4e771c8
Compare
This was referenced Oct 11, 2021
|
As per our offline discussion, I am forking the executor only and will be pushing forward asap with class based Executor over there, in order to jumpstart experimentation. Hopefully whatever works at graphql-executor can be integrated upstream as desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is used only by
buildExecutionContextand can be called there rather than exportedDepends on #3296