Allow graphql to pass through null values instead of ignoring them #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not seeing any trailing whitespace - any ideas? |
|
Thanks for investigating this. It looks like the linter is complaining about line 164 in values.js. I'd suggest configuring your IDE to trim trailing whitespace on save. Right now it's very much intentional how null values are treated because of how the GraphQL spec is written. I'm still working on that spec change which will determine the runtime behavior changes. |
| fieldValue = field.defaultValue; | ||
| } | ||
| if (!isNullish(fieldValue)) { | ||
| } else { |
There was a problem hiding this comment.
this seems like a mistake - did your unit tests pass or are we missing a test for this condition? As I read it, if a fieldValue is coerced to be undefined, then we set fieldValue to the default value, however never actually set it on the response object.
ghost
added
the
|
Closing this one due to staleness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As set out in #133 and graphql/graphql-spec#83