Expose getArgumentValues from root

[thomas-jeepe]

getArgumentValues is marked as internal and only exposed when you import from graphql/execution/values.

If you could expose it from the root index.js it would make importing it far easier in contexts without imports to relative files (a cdn for my case.)

The function is already used in production ready code in joinmonster and is necessary to get arguments from resolve info in field handlers. I don't see a good reason not to expose it.

[hayes]

I've seen several places that either use getArgumentValues, or suggest using it. Is there a reason it is currently not exposed from the index? Happy to make a PR if it's just an oversight

[benjie]

@IvanGoncharov do you know if there is a good reason for this to be internal only?

From what I can tell it receives a fair bit of use from the community, and it seems a bit too complex to just copy and paste into a project.

We're currently facing issues with there being no TypeScript declaration for this export, which is preventing us adopting GraphQL v16:

src/index.ts:20:10 - error TS2305: Module '"graphql"' has no exported member 'getArgumentValues'.

20 import { getArgumentValues } from "graphql/execution/values";
            ~~~~~~~~~~~~~~~~~


Found 1 error.

Surfacing this as a top level export would be appreciated 👍

[sachaw]

Is there any plans to work around this, It's currently blocking upgrading a number of large projects for me, and is starting to become a problem.
Thanks.

[IvanGoncharov]

@benjie @sachaw TS error that you experience should be fixed by c2435fd#diff-8fa9d179bb9179cc71534c34c492beb7bd8742db13f0fa1b6b269b5dc726a7f3
and released as [email protected].
Can you please test updating directly to 16.2.0?

As for exporting getArgumentValues it's internal function and was never intended to be part of public API.
However, since there are no alternatives to achieve the same functionality getArgumentValues defacto became part of public API.
So I will expose it, however, long-term solution would be to design it as a separate stage of the execution pipeline (similar to validate for example) so please expect breaking change in the next major release.

[saihaj]

@IvanGoncharov as discussed in WG today incorrect function was exposed.

[hiepxanh]

hope this will be resolve soon, I really expect this issue will be resolve since I'm using postgraphile and stuck with graphql version 15 for a long time :D

[paulbijancoch]

any news on this?