Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of GraphQLScalarType is outdated #2567

Closed
Tracked by #3150
Cito opened this issue May 20, 2020 · 3 comments · Fixed by #4279
Closed
Tracked by #3150

Documentation of GraphQLScalarType is outdated #2567

Cito opened this issue May 20, 2020 · 3 comments · Fixed by #4279

Comments

@Cito
Copy link
Member

Cito commented May 20, 2020

The documentation for the GraphQLScalarType is outdated compared with the current code. For instance, parseLiteal takes a valueNode and a variables parameter instead of just one valueAST parameter (I think that was changed in 0.12), and there are some more differences.

@overhead525
Copy link

@Cito this seems pretty straightforward. Have you completed this yet? If not, I'll get it done if you'll assign me.

@Cito
Copy link
Member Author

Cito commented May 24, 2020

@overhead525 no, haven't done anything about this yet. @IvanGoncharov can you assign it to him?

@yaacovCR
Copy link
Contributor

yaacovCR commented Oct 7, 2024

Changes in #3812 would also require documentation update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants