GraphQLScalarType: default 'parseLiteral' should handle variables (#2696

) Motivation #2657
graphql · Jul 10, 2020 · e3727fc · e3727fc
1 parent 9da7d35
commit e3727fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/type/__tests__/definition-test.js b/src/type/__tests__/definition-test.js
@@ -91,6 +91,9 @@ describe('Type System: Scalars', () => {
     expect(scalar.parseLiteral(parseValue('{ foo: "bar" }'))).to.equal(
       'parseValue: { foo: "bar" }',
     );
+    expect(
+      scalar.parseLiteral(parseValue('{ foo: { bar: $var } }'), { var: 'baz' }),
+    ).to.equal('parseValue: { foo: { bar: "baz" } }');
   });
 
   it('rejects a Scalar type without name', () => {

diff --git a/src/type/definition.js b/src/type/definition.js
@@ -591,7 +591,8 @@ export class GraphQLScalarType {
     this.serialize = config.serialize ?? identityFunc;
     this.parseValue = parseValue;
     this.parseLiteral =
-      config.parseLiteral ?? ((node) => parseValue(valueFromASTUntyped(node)));
+      config.parseLiteral ??
+      ((node, variables) => parseValue(valueFromASTUntyped(node, variables)));
     this.extensions = config.extensions && toObjMap(config.extensions);
     this.astNode = config.astNode;
     this.extensionASTNodes = undefineIfEmpty(config.extensionASTNodes);