Typeahead in VariableEditor #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asiandrummer
force-pushed
the
variables-typeahead
branch
from
2f5953c to
0f98ee2
Compare
asiandrummer
force-pushed
the
variables-typeahead
branch
from
0f98ee2 to
414ab0d
Compare
|
|
||
| // Match all variableDefinitions, even if they're not declared on the top. | ||
| // De-duplicate before filtering/sorting the list | ||
| let hintList = options.query.match(/\$\s*[_A-Za-z][_0-9A-Za-z]*/g); |
There was a problem hiding this comment.
I think this is probably not what we want - this will cause false-positive matches for something like "I'm a string with a $thing in it" and it also lacks the information we want to do a good type-ahead: the relevant input schema. Just having a list of variables only lets us typeahead names, but doesn't let us typeahead or lint values like allowed enum values or input objects with deeper fields.
|
I think this ultimately belongs in codemirror-graphql. That would allow us to share the lexicalDistance function, for example. The full typeahead we want will also leverage a lot of what we've already built for hinting and linting graphql. |
|
I agree - closing and moving this over to codemirror-graphql. |
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Jun 1, 2019
…ransform-flow-strip-types-6.21.0 Update babel-plugin-transform-flow-strip-types to the latest version 🚀
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Jun 5, 2019
…ransform-es2015-block-scoped-functions-6.22.0 Update babel-plugin-transform-es2015-block-scoped-functions to version 6.22.0 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Powered by CodeMirror. Simply search for all Variable (http://facebook.github.io/graphql/#Variable), de-duplicate/sort, and serve them up to the typeahead. Typeahead is trigger on typing letters/backspace/quotes (")/and underscore character.
Still have some UI improvements/testing to finish - just opening a PR for early reviews.