upgrade to graphql v17 including support for new incremental delivery format #3682
Conversation
🦋 Changeset detectedLatest commit: 5d0470c The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yaacovCR
force-pushed
the
new-incremental-format
branch
3 times, most recently
from
91eb569
to
02f62a2
Compare
|
I have enabled end to end tests and added v17 to the testing matrix. Unfortunately, there are some build errors that seem to be possibly on Main or possibly some sort of local development error on my side. It also appears that there are some new test errors with the language server possibly with loaders from graphql utils not playing nicely with v17, but tricky for me to debug… All end to end tests are passing however, so this is a start, but any help appreciated. :) |
yaacovCR
force-pushed
the
new-incremental-format
branch
4 times, most recently
from
c16072b
to
2a8fb24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3682 +/- ##
==========================================
- Coverage 67.60% 67.28% -0.32%
==========================================
Files 121 121
Lines 6968 7007 +39
Branches 2251 2260 +9
==========================================
+ Hits 4711 4715 +4
- Misses 2240 2275 +35
Partials 17 17
|
yaacovCR
force-pushed
the
new-incremental-format
branch
from
2a8fb24
to
7be28ad
Compare
yaacovCR
force-pushed
the
new-incremental-format
branch
from
7be28ad
to
5a99d03
Compare
submittes upstream with test at graphql/graphql-js#4160
packages/graphql-language-service-server/src/__tests__/MessageProcessor.spec.ts
Outdated
Show resolved
Hide resolved
packages/graphql-language-service/src/interface/__tests__/getDiagnostics-test.ts
Outdated
Show resolved
Hide resolved
packages/graphql-language-service/src/interface/__tests__/getDiagnostics-test.ts
Outdated
Show resolved
Hide resolved
packages/graphql-language-service/src/utils/__tests__/validateWithCustomRules-test.ts
Outdated
Show resolved
Hide resolved
not sure what these other packages are and why they are going to be released as a breaking change? |
yaacovCR
changed the title
yaacovCR
changed the title
* upgrade to graphql v17 including support for new incremental delivery format (#3682) * add support for new incremental delivery format * fix vitest * add patch for graphql-js bug submittes upstream with test at graphql/graphql-js#4160 * apply feedback * move patches! * some fixes * fix netlify/cypress * remove export * update changeset --------- Co-authored-by: Dimitri POSTOLOV <[email protected]> * Version Packages (#3715) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * prettier * fix e2e * update pr-graphql-compat-check.yml * prettier --------- Co-authored-by: Yaacov Rydzinski <[email protected]> Co-authored-by: Rikki Schulte <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
@dimaMachina next time, please do not merge a PR like this without asking. I need to manually revert many changes for us to return to spec compliance |
| @@ -0,0 +1,26 @@ | |||
| diff --git a/node_modules/graphql/execution/execute.js b/node_modules/graphql/execution/execute.js | |||
There was a problem hiding this comment.
@dimaMachina again, a reminder that this patch is being published to users. we should not be patching graphql before publishing as a reference ecosystem
There was a problem hiding this comment.
This patch was not published to users
This PR provides support for the next iteration of the incremental delivery response format. It is based on the proposed changes to
@graphql-tools/utils, that library being the inspiration for the most recent changes within this repository in #3580.I am not sure what the testing story will be for this PR as I am not too familiar with development with this repository. Feel free to point me in the right direction or to take this PR over. :)