Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer localStorage over window.localStorage #3646

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: 9d3d1dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@graphiql/toolkit Patch
@graphiql/react Patch
graphiql Patch
@graphiql/plugin-code-exporter Patch
@graphiql/plugin-explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.80%. Comparing base (fdec377) to head (9d3d1dd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3646   +/-   ##
=======================================
  Coverage   60.80%   60.80%           
=======================================
  Files         120      120           
  Lines        5620     5620           
  Branches     1489     1489           
=======================================
  Hits         3417     3417           
  Misses       1750     1750           
  Partials      453      453           
Files Coverage Δ
packages/graphiql-toolkit/src/storage/base.ts 64.10% <0.00%> (ø)
packages/graphiql-toolkit/src/storage/custom.ts 0.00% <0.00%> (ø)

Copy link
Contributor

github-actions bot commented Jul 4, 2024

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@dimaMachina dimaMachina merged commit 56c6f45 into main Jul 24, 2024
14 checks passed
@dimaMachina dimaMachina deleted the prefer-localstorage branch July 24, 2024 09:30
@acao acao mentioned this pull request Jul 11, 2024
dimaMachina added a commit to dimaMachina/graphiql that referenced this pull request Jul 24, 2024
add `packageManager` field in `package.json` (graphql#3654)

[graphiql] add `className` prop. Additional class names which will be appended to the GraphiQL container element (graphql#3643)

disable shrinking while changing the operation name

Update packages/graphiql-react/src/ui/tabs.css

Co-authored-by: Ted Thibodeau Jr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant