Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugins to webpack dev bundle #3403

Merged
merged 1 commit into from
Aug 12, 2023
Merged

add plugins to webpack dev bundle #3403

merged 1 commit into from
Aug 12, 2023

Conversation

acao
Copy link
Member

@acao acao commented Aug 12, 2023

this will complete #3374 and make it much easier to test #3346,

furthermore, this allows us to add standalone e2e tests for the plugin, that can run off the same e2e setup used by the graphiql project

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2023

⚠️ No Changeset found

Latest commit: 2794756

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #3403 (2794756) into main (2348641) will increase coverage by 0.10%.
Report is 8 commits behind head on main.
The diff coverage is 98.38%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3403      +/-   ##
==========================================
+ Coverage   55.75%   55.85%   +0.10%     
==========================================
  Files         110      110              
  Lines        5243     5256      +13     
  Branches     1426     1432       +6     
==========================================
+ Hits         2923     2936      +13     
  Misses       1897     1897              
  Partials      423      423              
Files Changed Coverage Δ
...nguage-service/src/utils/getVariablesJSONSchema.ts 94.59% <98.38%> (+0.71%) ⬆️

@acao acao merged commit d67d11d into main Aug 12, 2023
11 of 12 checks passed
@acao acao deleted the with-plugins branch August 12, 2023 18:09
acao added a commit that referenced this pull request Aug 12, 2023
acao added a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant