Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiline deprecation display issue #3349

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Conversation

acao
Copy link
Member

@acao acao commented Jul 14, 2023

fixes #3348

image

also a quick fix for the graphiql dev server

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

🦋 Changeset detected

Latest commit: ff69017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
graphiql Patch
@graphiql/react Patch
@graphiql/plugin-code-exporter Patch
@graphiql/plugin-explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao acao force-pushed the multiline-deprecation-3348 branch from 7a7ea16 to 4c58987 Compare July 14, 2023 09:03
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #3349 (ff69017) into main (119775e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3349   +/-   ##
=======================================
  Coverage   55.98%   55.98%           
=======================================
  Files         109      109           
  Lines        5209     5210    +1     
  Branches     1420     1421    +1     
=======================================
+ Hits         2916     2917    +1     
  Misses       1869     1869           
  Partials      424      424           
Impacted Files Coverage Δ
...ct/src/explorer/components/field-documentation.tsx 91.66% <ø> (ø)
...act/src/explorer/components/deprecation-reason.tsx 100.00% <100.00%> (ø)

@acao acao force-pushed the multiline-deprecation-3348 branch from 4c58987 to ff69017 Compare July 14, 2023 13:47
@acao acao merged commit 17069e7 into main Jul 16, 2023
@acao acao deleted the multiline-deprecation-3348 branch July 16, 2023 10:00
@acao acao mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Issue with Multiline Deprecation Reason
1 participant