Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code exporter on early init, new hooks: useOperationsEditorState() #3341

Merged
merged 2 commits into from
Jul 16, 2023

Conversation

acao
Copy link
Member

@acao acao commented Jul 12, 2023

this abstracts away some editor specific details
until we can leverage <Suspense />

  • add useOperationsEditorState()
  • add useVariablesEditorState()
  • match up @graphiql/react globals
  • simplify plugin implementations

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

🦋 Changeset detected

Latest commit: 115bbfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphiql/plugin-code-exporter Patch
@graphiql/plugin-explorer Patch
@graphiql/react Patch
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #3341 (115bbfb) into main (119775e) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3341      +/-   ##
==========================================
- Coverage   55.98%   55.69%   -0.29%     
==========================================
  Files         109      110       +1     
  Lines        5209     5236      +27     
  Branches     1420     1424       +4     
==========================================
  Hits         2916     2916              
- Misses       1869     1896      +27     
  Partials      424      424              
Impacted Files Coverage Δ
packages/graphiql-react/src/editor/hooks.ts 38.58% <0.00%> (-4.03%) ⬇️

... and 1 file with indirect coverage changes

this abstracts away some editor specific details
until we can leverage `<Suspense />`

- add useOperationsEditorState()
- add useVariablesEditorState()
- match up @graphiql/react globals
- simplify plugin implementations
@acao acao force-pushed the explorer-editor-bugfix branch from 35937bd to 838a013 Compare July 14, 2023 13:48
@acao acao changed the title new hooks: useOperationsEditorState() fix code exporter on early init, new hooks: useOperationsEditorState() Jul 14, 2023
@acao acao merged commit e4a3620 into main Jul 16, 2023
@acao acao deleted the explorer-editor-bugfix branch July 16, 2023 10:00
@acao acao mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant