Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show dropdown for execute button if an operation is currently running #2885

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Do not show dropdown for execute button if an operation is currently running #2885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/poor-vans-kiss.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'graphiql': patch
'@graphiql/react': patch
---

Fix stop execution button showing a dropdown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fix stop execution button showing a dropdown
Bugfix: Stop execution button from showing a dropdown during operation fetch

2 changes: 1 addition & 1 deletion packages/graphiql-react/src/toolbar/execute.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function ExecuteButton() {
'aria-label': label,
};

return hasOptions ? (
return hasOptions && !isFetching ? (
<Menu>
<Tooltip label={label}>
<Menu.Button {...buttonProps} />
Expand Down