Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose PluginContextProvider #2839

Conversation

ClemensSahs
Copy link
Contributor

Any other ContextProvider are exposed, with exception PluginContextProvider.

So in my opinion #2674 only miss this expose

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

🦋 Changeset detected

Latest commit: 355a1d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphiql/react Patch
@graphiql/plugin-explorer Patch
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 25, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Collaborator

@thomasheyenbrock thomasheyenbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is definitely an oversight, good catch! Can you please also re-export the PluginContextProvider in the mock file of the graphiql package here:

(For context, we're mocking part of the package for testing and just re-export everything else . It's quite annoying to keep this in sync, but nobody found the time to improve that yet.)

@ClemensSahs
Copy link
Contributor Author

That is definitely an oversight, good catch! Can you please also re-export the PluginContextProvider in the mock file of the graphiql package here:

(For context, we're mocking part of the package for testing and just re-export everything else . It's quite annoying to keep this in sync, but nobody found the time to improve that yet.)

yes, sure. DONE ;)

side context:

only following things that are mocked right anything else will be re-exported, right?

useHeaderEditor
useQueryEditor
useResponseEditor
useVariableEditor
HeaderEditor
QueryEditor
ResponseEditor
VariableEditor

@thomasheyenbrock
Copy link
Collaborator

@ClemensSahs CI has some failures, can you take a look?

Copy link
Collaborator

@thomasheyenbrock thomasheyenbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a changeset, thanks again!

@thomasheyenbrock thomasheyenbrock merged commit 682ad06 into graphql:main Oct 28, 2022
@acao acao mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants