-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose PluginContextProvider #2839
expose PluginContextProvider #2839
Conversation
🦋 Changeset detectedLatest commit: 355a1d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is definitely an oversight, good catch! Can you please also re-export the PluginContextProvider
in the mock file of the graphiql
package here:
export { |
(For context, we're mocking part of the package for testing and just re-export everything else . It's quite annoying to keep this in sync, but nobody found the time to improve that yet.)
yes, sure. DONE ;) side context: only following things that are mocked right anything else will be re-exported, right?
|
@ClemensSahs CI has some failures, can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added a changeset, thanks again!
Any other ContextProvider are exposed, with exception PluginContextProvider.
So in my opinion #2674 only miss this expose